Re: [U-Boot] [PATCH 2/4] build/mkconfig: Add EXTRA_OPTS argument to make to modify build

[Mike Frysinger]

On Thursday, June 02, 2011 15:34:58 Matthew McClintock wrote:
> --- a/mkconfig
> +++ b/mkconfig
> @@ -81,6 +81,12 @@ if [ "${ARCH}" -a "${ARCH}" != "${arch}" ]; then
>       exit 1
>  fi
> 
> +if [ -z "${options}" ] ; then
> +options+=$EXTRA_OPTS
> +else
> +options+=,$EXTRA_OPTS
> +fi

style is broken (lacking indentation), and the "+=" operator is not in the 
POSIX shell spec
-mike

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot