Hi Jonas, On Fri, 28 Mar 2025 at 12:19, Jonas Karlman <jo...@kwiboo.se> wrote: > > Hi Simon, > > Patch 05 to 10 should still be split out to a separate series. > > They help fix an issue that already have a different conflicting patch > on mailing list [1]. > > The request to split these patches out was to help/ease work for other > U-Boot developers such as myself. I have a follow up patch to split out > HASH and to add support for using crc32 as hash algo, for an upcoming > RK3506 series. And I have already send a separate series to add RAM boot > that depends on the fit-template added in patch 08, see [2]. > > Still keeping these rockchip: dts: patches that are ready to be merged > in a series that in v3 still does not apply to master or next is > disappointing. And because it is not possible to apply this series, a > proper review and testing has not yet been done, something that is just > delaying your work more than it has to. > > I can send these patches as a separate series if you do not have time to > split these patches out to a separate series, and would also include my > HASH crc32 patch.
Yes, please go ahead and thank you. You might also consider the skip-at-start patches at the end. I have several rockchip boards in my lab, so I'm pretty confident about the general changes. But perhaps one board is different from the others. I doubt anyone has all boards. Regards, SImon > > [1] > http://lore.kernel.org/r/20250220-has_rom-u-boot-rockchip-spi-bin-v2-3-d1768ee87...@cherry.de > [2] http://lore.kernel.org/r/20250220231358.432367-3-jo...@kwiboo.se > > Regards, > Jonas > > On 2025-03-28 16:34, Simon Glass wrote: > > At present simple-bin-spi relies on the u-boot.itb file created by the > > simple-bin image. Use the template to avoid this, since Binman may > > change to process images in parallel in the future. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > Reviewed-by: Jonas Karlman <jo...@kwiboo.se> > > Suggested-by: Jonas Karlman <jo...@kwiboo.se> > > --- > > > > Changes in v3: > > - Keep the filename for the SPI FIT > > > > arch/arm/dts/rockchip-u-boot.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/dts/rockchip-u-boot.dtsi > > b/arch/arm/dts/rockchip-u-boot.dtsi > > index 1e4d6f71123..fb304540787 100644 > > --- a/arch/arm/dts/rockchip-u-boot.dtsi > > +++ b/arch/arm/dts/rockchip-u-boot.dtsi > > @@ -207,8 +207,8 @@ > > > > #ifdef HAS_FIT > > fit { > > - type = "blob"; > > filename = "u-boot.itb"; > > + insert-template = <&common_part>; > > #else > > u-boot-img { > > #endif >
