On 3/24/25 1:39 PM, Quentin Schulz wrote:
Hi Marek,
Hi,
On 3/22/25 10:55 PM, Marek Vasut wrote:
Rename the variable and add ENV_ prefix, so that all configuration
options which are related to environment would have an CONFIG_ENV_
prefix. No functional change.
Use ENV_SDMMC_DEVICE_INDEX to clarify this is the SD/MMC device
index, a number, as enumerated by U-Boot. Update the help text
accordingly.
I disagree with this part of the rename (MMC->SDMMC), our drivers all
are using mmc (env/mmc.*, drivers/mmc/*, cmd/mmc.c, ...) for both SD and
MMC. We also have ENV_IS_IN_MMC which is for both. I don't think it's
worth the confusion.
My main problem is, that it is confusing to call everything _mmc_ even
if most of it also applies to SD . There is no way to discern parts
which are MMC specific from parts which are common to SD and MMC now.
SYS_ prefix to ENV_ is fine though!
DEVICE_INDEX could be DEV_IDX too if we want to shorten the symbol name.
No abbreviations please, it only adds to confusion.
--
Best regards,
Marek Vasut
