Hi Marek,
On 3/22/25 10:55 PM, Marek Vasut wrote:
Rename the variable and add ENV_ prefix, so that all configuration
options which are related to environment would have an CONFIG_ENV_
prefix. No functional change.
Use ENV_SDMMC_EMMC_HW_PARTITION to clarify this is the eMMC hardware
Same disagreement as previous patch for the MMC->SDMMC rename, I haven't
checked the next patches but the same remark would apply as well.
[...]
diff --git a/env/Kconfig b/env/Kconfig
index 6bb882baa9e..fbc03777040 100644
--- a/env/Kconfig
+++ b/env/Kconfig
@@ -219,7 +219,7 @@ config ENV_IS_IN_MMC
Specifies which MMC device the environment is stored in.
- CONFIG_SYS_MMC_ENV_PART (optional):
+ CONFIG_ENV_SDMMC_EMMC_HW_PARTITION (optional):
Specifies which MMC partition the environment is stored in. If not
"which eMMC hardware partition"
set, defaults to partition 0, the user area. Common values might be
Outside of this git context:
"(first eMMC hardware boot partition), 2 (second eMMC hardware boot
partition)" maybe?
@@ -252,7 +252,7 @@ config ENV_IS_IN_MMC
This value may also be positive or negative; this is handled in the
same way as CONFIG_ENV_OFFSET.
- In case CONFIG_SYS_MMC_ENV_PART is 1 (i.e. environment in eMMC boot
+ In case CONFIG_ENV_SDMMC_EMMC_HW_PARTITION is 1 (i.e. environment in
eMMC boot
partition) then setting CONFIG_ENV_OFFSET_REDUND to the same value
as CONFIG_ENV_OFFSET makes use of the second eMMC boot partition for
the redundant environment copy.
@@ -676,7 +676,7 @@ config ENV_SDMMC_DEVICE_INDEX
The index is often derived from DT aliases mmcN node ordering, and
matches the 'mmc list' command output.
-config SYS_MMC_ENV_PART
+config ENV_SDMMC_EMMC_HW_PARTITION
int "mmc partition number"
Should we say "eMMC hardware partition number" here?
Cheers,
Quentin
