Hi Tony, > -----Original Message----- > From: Tom Rini <tr...@konsulko.com> > Sent: Saturday, March 15, 2025 9:29 AM > To: u-boot@lists.denx.de > Cc: Chee, Tien Fong <tien.fong.c...@altera.com> > Subject: [PATCH] ARM: socfpga: Drop incorrect imply > SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION* > > The use of both "imply > SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION" and "imply > SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE" here is wrong > as those are both part of the same choice statement. Furthermore you > cannot select/imply something from a choice statement, it must be a > "default ... > if ..." construct within the choice statement in question.
I think the imply here which allows for overwritten in defconfig. To support the "default....if...", new config for platform specific in Kconfig is required. Is there any other approach better to support this? So latter approach is preferred? > > Signed-off-by: Tom Rini <tr...@konsulko.com> > --- > Cc: Tien Fong Chee <tien.fong.c...@altera.com> > --- > arch/arm/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index > cf08fe63f1e7..071fbf1fb202 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1163,8 +1163,6 @@ config ARCH_SOCFPGA > imply SPL_DM_SPI_FLASH > imply SPL_LIBDISK_SUPPORT > imply SPL_MMC > - imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION > - imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE > imply SPL_SPI_FLASH_SUPPORT > imply SPL_SPI > imply L2X0_CACHE > -- > 2.43.0 Best regards Tien Fong
