Hi Marek,

On 2/11/25 5:06 PM, Marek Vasut wrote:
On 2/11/25 2:47 PM, Quentin Schulz wrote:

Hi,

+    if (CONFIG_SYS_MMC_ENV_PART != 1)

Oof what a terrible name for the actual meaning :/

           MMC hardware partition device number on the platform where the
           environment is stored.  Note that this is not related to any software            defined partition table but instead if we are in the user area, which is            partition 0 or the first boot partition, which is 1 or some other defined
           partition.

Would benefit from a small comment making this less confusing in the code.

Maybe CONFIG_SYS_MMC_ENV_PART should be renamed instead ... to some CONFIG_ENV_MMC_HW_PART


config ENV_MMC_IN_BOOT_PART
        bool "env in eMMC boot partition"
        help
Store the environment in eMMC boot partition (y) or in user partition (n).

Maybe?

Out of scope for this patch though :)

Cheers,
Quentin

Reply via email to