On Wed, 29 Jan 2025 at 03:30, Yannic Moog <y.m...@phytec.de> wrote: > > When having an entry that is marked as optional and is missing, the > following output is observed: > > CFGS spl/u-boot-spl.cfgout > BINMAN .binman_stamp > Image 'image' has faked external blobs and is non-functional: tee.bin > > Image 'image' is missing optional external blobs but is still functional: > tee-os > > /binman/section/fit/images/tee/tee-os (tee.bin): > See the documentation for your board. You may need to build Open Portable > Trusted Execution Environment (OP-TEE) and build with TEE=/path/to/tee.bin > > Some images are invalid > make: *** [Makefile:1135: .binman_stamp] Error 103 > > To solve this contradictory messaging, when checking the faked blob > list, remove entries that are allowed to be missing. > > This also fixes the testFitFirmwareLoadables binman test: > > FAIL: testFitFirmwareLoadables > (binman.ftest.TestFunctional.testFitFirmwareLoadables) > Test an image with an FIT that use fit,firmware > ---------------------------------------------------------------------- > AssertionError: 0 != 103 > > This test failed due to the exposed bug when testing with faked external > blobs. > > Signed-off-by: Yannic Moog <y.m...@phytec.de> > --- > tools/binman/control.py | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) >
Reviewed-by: Simon Glass <s...@chromium.org> Ideally your updated tests would be in this commit.
