On 1/8/25 5:40 PM, Caleb Connolly via groups.io wrote:
Hi Alexey,
Thanks for the patch! Really happy to see support for this new platform.
On 08/01/2025 12:59, Alexey Minnekhanov wrote:
Apparently not all GDSCs are the same. In Linux driver, depending on which
GDSC flags are set, different status register is checked when powering it
on/off. And on top of that, different bit inside that register is tested.
Port missing parts from Linux driver to U-Boot:
- add GDSC flags;
- adjust logic when checking GDSC status to match one in Linux driver.
Sorry it's a bit of a pain, but could you split this into two patch and
adjust the ordering so we don't risk breaking someones bisect if they
land here. I'd propose:
Patch 1: as-is
Patch 2: add the flags enum and adjust struct qcom_power_map
Patch 3: would be the "port to new flags" patch
Patch 4: adjust qcom_power_set() (the bulk of this patch)
Patch 5: add sdm660 clock driver
does this make sense?
Yes, I think I understand what you mean, will try to rework in next
version.
