On 2025/1/29 23:24, Quentin Schulz wrote:
From: Quentin Schulz <quentin.sch...@cherry.de>
The build system uses HAVE_VENDOR_COMMON_LIB to automatically include
board/$(VENDOR)/common/Makefile, therefore let's use that to implicitly
include board/theobroma-systems/common/Makefile and compile the common.c
file when building proper.
Signed-off-by: Quentin Schulz <quentin.sch...@cherry.de>
Reviewed-by: Kever Yang <kever.y...@rock-chips.com>
Thanks,
- Kever
---
board/theobroma-systems/common/Makefile | 9 +++++++++
board/theobroma-systems/jaguar_rk3588/Makefile | 3 ---
board/theobroma-systems/puma_rk3399/Makefile | 3 ---
board/theobroma-systems/ringneck_px30/Makefile | 3 ---
board/theobroma-systems/tiger_rk3588/Makefile | 3 ---
5 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/board/theobroma-systems/common/Makefile
b/board/theobroma-systems/common/Makefile
new file mode 100644
index
0000000000000000000000000000000000000000..c1cadb4b913e8da8bc182f8142b16b2443891343
--- /dev/null
+++ b/board/theobroma-systems/common/Makefile
@@ -0,0 +1,9 @@
+#
+# Copyright (c) 2025 Cherry Embedded Solutions GmbH
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+ifneq ($(CONFIG_XPL_BUILD),y)
+obj-y += common.o
+endif
diff --git a/board/theobroma-systems/jaguar_rk3588/Makefile
b/board/theobroma-systems/jaguar_rk3588/Makefile
index
d43bf194b687cacc556491ecc9041c4da8fd207c..38b73d2846c48f8afad31349d0cf3c593969366e
100644
--- a/board/theobroma-systems/jaguar_rk3588/Makefile
+++ b/board/theobroma-systems/jaguar_rk3588/Makefile
@@ -5,6 +5,3 @@
#
obj-y += jaguar_rk3588.o
-ifneq ($(CONFIG_XPL_BUILD),y)
-obj-y += ../common/common.o
-endif
diff --git a/board/theobroma-systems/puma_rk3399/Makefile
b/board/theobroma-systems/puma_rk3399/Makefile
index
2256e72cda1986ffa9502447a5d7d975eaea504b..d962b56f11123afe4573b64b0d8728fc0a0aa576
100644
--- a/board/theobroma-systems/puma_rk3399/Makefile
+++ b/board/theobroma-systems/puma_rk3399/Makefile
@@ -5,6 +5,3 @@
#
obj-y += puma-rk3399.o
-ifneq ($(CONFIG_XPL_BUILD),y)
-obj-y += ../common/common.o
-endif
diff --git a/board/theobroma-systems/ringneck_px30/Makefile
b/board/theobroma-systems/ringneck_px30/Makefile
index
4d108f2d011f07d0fff141158af39a55726348f7..31ada1a69422cdb7bb85bc6c737e2a98187bc62c
100644
--- a/board/theobroma-systems/ringneck_px30/Makefile
+++ b/board/theobroma-systems/ringneck_px30/Makefile
@@ -5,6 +5,3 @@
#
obj-y += ringneck-px30.o
-ifneq ($(CONFIG_XPL_BUILD),y)
-obj-y += ../common/common.o
-endif
diff --git a/board/theobroma-systems/tiger_rk3588/Makefile
b/board/theobroma-systems/tiger_rk3588/Makefile
index
94b0859eb356c31c3358c453ae46ea8cc64a50c0..900647735fb129fc9252a1cb14ed19d74e8026a0
100644
--- a/board/theobroma-systems/tiger_rk3588/Makefile
+++ b/board/theobroma-systems/tiger_rk3588/Makefile
@@ -5,6 +5,3 @@
#
obj-y += tiger_rk3588.o
-ifneq ($(CONFIG_XPL_BUILD),y)
-obj-y += ../common/common.o
-endif
---
base-commit: a2b489b170f8382f746202c36616eaf2bc38fe86
change-id: 20250129-tsd-have_vendor_common_lib-42c4dd70c3e4
Best regards,
