On Wed, Jan 15, 2025 at 4:23 PM Chanho Park <parkc...@gmail.com> wrote:

> When building without DHCP/PXE configurations (NET disabled),
> compilation errors may occur due to mismatched bootargs.
> Ensure bootargs related to DHCP/PXE are not enabled if the
> corresponding commands are disabled.
>
> include/config_distro_bootcmd.h:443:9: error: expected ‘}’ before
> ‘BOOT_TARGET_DEVICES_references_PXE_without_CONFIG_CMD_DHCP_or_PXE’
>   443 |         
> BOOT_TARGET_DEVICES_references_PXE_without_CONFIG_CMD_DHCP_or_PXE
>       |         
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Chanho Park <parkc...@gmail.com>

Makes sense to me:
Acked-by: Linus Walleij <linus.wall...@linaro.org>

Maybe expand the commit message to show how the current
config strings for PXE or DHCP boot will be passed on to the
actual strings landing on the target.

Can we enable both PXE and DHCP at the same time? I hope
not because then the result will be a mishmash.

Yours,
Linus Walleij

Reply via email to