On Monday 16 May 2011 01:31 AM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<1305472900-4004-16-git-send-email-ane...@ti.com> you wrote: >> Add support for the SDRAM controller (EMIF). >> >> Signed-off-by: Aneesh V<ane...@ti.com> >> V2: >> * Changes for makefile changes >> * Minor corrections in do_lpddr2_init() >> * Minor corrections to read_idle interval calculation >> * Sanity test of memory after doing the initialization >> * Fixed warnings reported with with latest GCC compilers >> --- >> arch/arm/cpu/armv7/omap4/Makefile | 3 + >> arch/arm/cpu/armv7/omap4/board.c | 2 +- >> arch/arm/cpu/armv7/omap4/emif.c | 298 +++++++++++ >> arch/arm/cpu/armv7/omap4/sdram_elpida.c | 118 +++++ >> arch/arm/include/asm/arch-omap4/emif.h | 719 >> +++++++++++++++++++++++++++ >> arch/arm/include/asm/arch-omap4/omap4.h | 11 + >> arch/arm/include/asm/arch-omap4/sys_proto.h | 1 + >> include/configs/omap4_sdp4430.h | 5 - >> spl/board/ti/omap4.mk | 9 +- >> 9 files changed, 1159 insertions(+), 7 deletions(-) >> create mode 100644 arch/arm/cpu/armv7/omap4/emif.c >> create mode 100644 arch/arm/cpu/armv7/omap4/sdram_elpida.c >> create mode 100644 arch/arm/include/asm/arch-omap4/emif.h > > I'm really surprised to see this patch at this position in the middle > of this patch series. > > Can you please explain why you think this is the right place for it?
This is roughly the sequence I followed. 1. Make the basic infrastructure. 2. Have a working skeleton of SPL(Just boots but doesn't do the loading part yet) 3. Add mux support. 4. Add clock initialization 5. Add SDRAM initialization(clock patch is a pre-requisite for this) 6. Add support for MMC initialization and loading of U-Boot 7. Add FAT mode boot support. 8. Add support for Panda I think this will change a bit when I do some squashing as you suggested. best regards, Aneesh _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
