Hi Raymond,

Le 09/12/2024 à 17:13, Raymond Mao a écrit :

*This Mail comes from Outside of SoftAtHome: *Do not answer, click links or open attachments unless you recognize the sender and know the content is safe.**

Hi Philippe,

On Mon, 9 Dec 2024 at 04:42, Philippe Reynes <philippe.rey...@softathome.com> wrote:

    Adds a test for the function sha256_hmac

    Signed-off-by: Philippe Reynes <philippe.rey...@softathome.com>
    ---
     test/lib/Makefile           |   1 +
     test/lib/test_sha256_hmac.c | 108
    ++++++++++++++++++++++++++++++++++++
     2 files changed, 109 insertions(+)
     create mode 100644 test/lib/test_sha256_hmac.c

    diff --git a/test/lib/Makefile b/test/lib/Makefile
    index f516d001747..4c0abcba81a 100644
    --- a/test/lib/Makefile
    +++ b/test/lib/Makefile
    @@ -24,6 +24,7 @@ obj-$(CONFIG_ERRNO_STR) += test_errno_str.o
     obj-$(CONFIG_UT_LIB_ASN1) += asn1.o
     obj-$(CONFIG_UT_LIB_RSA) += rsa.o
     obj-$(CONFIG_AES) += test_aes.o
    +obj-$(CONFIG_SHA256) += test_sha256_hmac.o
     obj-$(CONFIG_GETOPT) += getopt.o
     obj-$(CONFIG_CRC8) += test_crc8.o
     obj-$(CONFIG_UT_LIB_CRYPT) += test_crypt.o
    diff --git a/test/lib/test_sha256_hmac.c b/test/lib/test_sha256_hmac.c
    new file mode 100644
    index 00000000000..473922bd9b0
    --- /dev/null
    +++ b/test/lib/test_sha256_hmac.c
    @@ -0,0 +1,108 @@
    +// SPDX-License-Identifier: GPL-2.0+
    +/*
    + * Copyright (c) 2024 Philippe Reynes
    <philippe.rey...@softathome.com>
    + *
    + * Unit tests for sha256_hmac functions
    + */
    +
    +#include <command.h>
    +#include <test/lib.h>
    +#include <test/test.h>
    +#include <test/ut.h>
    +#include <u-boot/sha256.h>
    +
    +struct test_sha256_hmac_s {
    +       unsigned char *key;
    +       int keylen;
    +       unsigned char *input;
    +       int ilen;
    +       unsigned char *expected;
    +};
    +
    +/*
    + * data comes from:
    + * https://datatracker.ietf.org/doc/html/rfc4231
    <https://datatracker.ietf.org/doc/html/rfc4231>
    + */
    +static unsigned char key_test1[] = {
    +       0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b,
    +       0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0b };
    +
    +static unsigned char input_test1[] = {
    +       0x48, 0x69, 0x20, 0x54, 0x68, 0x65, 0x72, 0x65 };
    +
    +static unsigned char expected_test1[] = {
    +       0xb0, 0x34, 0x4c, 0x61, 0xd8, 0xdb, 0x38, 0x53,
    +       0x5c, 0xa8, 0xaf, 0xce, 0xaf, 0x0b, 0xf1, 0x2b,
    +       0x88, 0x1d, 0xc2, 0x00, 0xc9, 0x83, 0x3d, 0xa7,
    +       0x26, 0xe9, 0x37, 0x6c, 0x2e, 0x32, 0xcf, 0xf7 };
    +
    +static unsigned char key_test2[] = { 0x4a, 0x65, 0x66, 0x65 };
    +
    +static unsigned char input_test2[] = {
    +       0x77, 0x68, 0x61, 0x74, 0x20, 0x64, 0x6f, 0x20,
    +       0x79, 0x61, 0x20, 0x77, 0x61, 0x6e, 0x74, 0x20,
    +       0x66, 0x6f, 0x72, 0x20, 0x6e, 0x6f, 0x74, 0x68,
    +       0x69, 0x6e, 0x67, 0x3f };
    +
    +static unsigned char expected_test2[] = {
    +       0x5b, 0xdc, 0xc1, 0x46, 0xbf, 0x60, 0x75, 0x4e,
    +       0x6a, 0x04, 0x24, 0x26, 0x08, 0x95, 0x75, 0xc7,
    +       0x5a, 0x00, 0x3f, 0x08, 0x9d, 0x27, 0x39, 0x83,
    +       0x9d, 0xec, 0x58, 0xb9, 0x64, 0xec, 0x38, 0x43 };
    +
    +static struct test_sha256_hmac_s test_sha256_hmac[] = {
    +       {
    +               .key = key_test1,
    +               .keylen = sizeof(key_test1),
    +               .input = input_test1,
    +               .ilen = sizeof(input_test1),
    +               .expected = expected_test1,
    +       },
    +       {
    +               .key = key_test2,
    +               .keylen = sizeof(key_test2),
    +               .input = input_test2,
    +               .ilen = sizeof(input_test2),
    +               .expected = expected_test2,
    +       },
    +};
    +
    +static int _lib_test_sha256_hmac_run(struct unit_test_state *uts,
    +                                    unsigned char *key, int keylen,
    +                                    unsigned char *input, int ilen,
    +                                    unsigned char *expected)
    +{
    +       unsigned char output[32];
    +
    +       sha256_hmac(key, keylen, input, ilen, output);
    +       ut_asserteq_mem(expected, output, 32);
    +
    +       return 0;
    +}
    +
    +static int lib_test_sha256_hmac_run(struct unit_test_state *uts,
    +                                   struct test_sha256_hmac_s *test)
    +{
    +       unsigned char *key = test->key;
    +       int keylen = test->keylen;
    +       unsigned char *input = test->input;
    +       int ilen = test->ilen;
    +       unsigned char *expected = test->expected;
    +
    +       return _lib_test_sha256_hmac_run(uts, key, keylen, input,
    ilen, expected);
    +}
    +
    +static int lib_test_sha256_hmac(struct unit_test_state *uts)
    +{
    +       int i, ret = 0;
    +
    +       for (i = 0; i < ARRAY_SIZE(test_sha256_hmac); i++) {
    +               ret = lib_test_sha256_hmac_run(uts,
    &test_sha256_hmac[i]);
    +               if (ret)
    +                       break;
    +       }
    +
    +       return ret;
    +}
    +
    +LIB_TEST(lib_test_sha256_hmac, 0);


Can we extend the test cases with:
keys longer than 64 bytes to verify proper key hashing.


Yes, I have added a test for each test vector provided in
https://datatracker.ietf.org/doc/html/rfc4231

And one of them has a key longer than 64.



Regards,
Raymond


Regards,
Philippe

Reply via email to