On Mon, Dec 02, 2024 at 01:24:27AM +0100, Heinrich Schuchardt wrote:
> Am 2. Dezember 2024 01:12:36 MEZ schrieb Simon Glass <s...@chromium.org>:
> >It is a bit of a pain to log EFI boot-services calls at present. The
> >output goes to the console so cannot easily be inspected later. Also it
> >would be useful to be able to store the log and review it later, perhaps
> >after something has gone wrong.
> >
> >This series makes a start on implementing a log-to-buffer feature. It
> >provides a simple 'efidebug log' command to inspect the buffer. For now,
> >only memory allocations are logged.
> 
> In my previous review I suggested to move your work to the level of the 
> logging library lib/log.c.
> 
> Why are you reiterating your series without exposing why an EFI specific 
> solution. should be desireable?

Even with
https://lore.kernel.org/u-boot/CAFLszTgE_HZEbG7B09_oo=XfugvH07ix=_0eosgaeq+khya...@mail.gmail.com/
it is unclear why this patch series rather than either/both:
- Expand CONFIG_LOG to have a "file" or "bloblist" option
- Use CONFIG_TRACE

Do not match your needs. Especially the second option.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to