Hi Siddharth On 11/24/2024 12:37 PM, Siddharth Vadapalli wrote:
Commit a4d5e5daa847 ("board: sk-am69: Define capsule update firmware info") updated the "dfu_alt_info" variable to support use-cases with Serial Flash. However, this breaks use-cases where interface is not Serial Flash ("sf"). Fix this by setting "dfu_alt_info" only when the interface is "sf".Fixes: a4d5e5daa847 ("board: sk-am69: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli <s-vadapa...@ti.com>
AFAIR, DFU in general is not enabled on J784S4 Can i request to enable DFU along with this update.
--- v1: https://patchwork.ozlabs.org/project/uboot/patch/20241124051545.382397-6-s-vadapa...@ti.com/ Changes since v1: - Replaced "SPI Flash" with "Serial Flash" everywhere. Regards, Siddharth. board/ti/j784s4/evm.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/board/ti/j784s4/evm.c b/board/ti/j784s4/evm.c index 548dbd5925..d915aee48f 100644 --- a/board/ti/j784s4/evm.c +++ b/board/ti/j784s4/evm.c @@ -42,7 +42,13 @@ struct efi_capsule_update_info update_info = { #if IS_ENABLED(CONFIG_SET_DFU_ALT_INFO) void set_dfu_alt_info(char *interface, char *devstr) { - if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT)) + /* + * Since the EFI Capsule support is enabled only for Serial Flash, + * update the "dfu_alt_info" environment variable only if the + * interface happens to be "sf" (Serial Flash). + */ + if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT) && + (strcmp(interface, "sf") == 0)) env_set("dfu_alt_info", update_info.dfu_string); } #endif
