Thanks Simon, On Mon, 11 Nov 2024 at 15:03, Simon Glass <s...@chromium.org> wrote: > > On Sun, 10 Nov 2024 at 01:32, Ilias Apalodimas > <ilias.apalodi...@linaro.org> wrote: > > > > With the recent changes of lwip & mbedTLS we can now download from > > https:// urls instead of just http://. > > Adjust our wget lwip version parsing to support both URLs. > > While at it adjust the default TCP window for QEMU since https seems to > > require at least 16384 > > > > Signed-off-by: Ilias Apalodimas <ilias.apalodi...@linaro.org> > > --- > > cmd/Kconfig | 19 +++++++++++ > > net/lwip/Kconfig | 2 +- > > net/lwip/wget.c | 86 +++++++++++++++++++++++++++++++++++++++++++----- > > 3 files changed, 97 insertions(+), 10 deletions(-) > > Reviewed-by: Simon Glass <s...@chromium.org> > > Some nits / questions > > I am not sure what mbedtls_hardware_poll() is,
It's an entropy collector used by mbedTLS to ensure the platform has enough entropy. It's required if your platform doesn't support standards like the /dev/urandom or Windows CryptoAPI. > but if @len is too > short, would it be acceptable to return an error? How many bytes is it > requesting in the https case? If you don't return enough entropy https:// will fail and mbedTLS & lwIP will print an error. I think we currently use 128 and the default for mbedTLS is 32. > > uclass_first_device() if you want the first device, not > uclass_get_device(...0) Sure Thanks /Ilias > > Regards, > Simon
