Re: [PATCH 1/1] arm: provide noncached_set_region prototype to fix build

[Tom Rini]

On Wed, Oct 16, 2024 at 01:24:55PM +0200, Jonas Jelonek wrote:

> Due to the removal of weak functions in 7d6cee2cd0 ("cmd: cache: Remove
> weak function"), uboot fails to compile after updating to v2024.10 for

Should be "U-Boot" but I can fix that on applying.

> mediatek target in OpenWrt with GCC-14 with error:
> cmd/cache.c: In function 'do_dcache':
> cmd/cache.c:57:25: error: implicit declaration of function
>       'noncached_set_region' [-Wimplicit-function-declaration]
> 
> Thus, provide a prototype in arm's include/asm/system.h to fix a build
> error in cmd/cache.c, since related prototypes are also located there.
> Also add an include of asm/system.h in cmd/cache.c to have the function
> available there.
> 
> The issue occured after the update of uboot-mediatek in OpenWrt to
> v2024.10, in combination with GCC-14 toolchain. It was reported and
> discussed in https://github.com/openwrt/openwrt/issues/16697, and
> temporarily fixed with
> https://github.com/openwrt/openwrt/commit/92ca322dd1f48158b8829fec59319a12e4ae4295.
> 
> Signed-off-by: Jonas Jelonek <jelonek.jo...@gmail.com>
> Cc: Tom Rini <tr...@konsulko.com>

Thanks!

Reviewed-by: Tom Rini <tr...@konsulko.com>
Link: https://github.com/openwrt/openwrt/issues/16697
Link: 
https://github.com/openwrt/openwrt/commit/92ca322dd1f48158b8829fec59319a12e4ae4295
Fixes: 7d6cee2cd0 ("cmd: cache: Remove weak function")

-- 
Tom

signature.asc
Description: PGP signature