In OpenWrt project, an issue recently occured after updating u-boot for
mediatek to v2024.10. When building with GCC-14 toolchain, it fails
with:
cmd/cache.c: In function 'do_dcache':
cmd/cache.c:57:25: error: implicit declaration of function
'noncached_set_region' [-Wimplicit-function-declaration]
It is presumably caused by commit 7d6cee2cd0 ("cmd: cache: Remove weak
functions") which removes the prototypes. Arm architecture provides an
implementation for 'noncached_set_region', however it is not available
to 'cmd/cache.c'.
The issue was already discussed in
https://github.com/openwrt/openwrt/issues/16697
and temporarily fixed downstream in
https://github.com/openwrt/openwrt/commit/92ca322dd1f48158b8829fec59319a12e4ae4295.
Another user reported the issue in u-boot too, and confirmed the
solution working (https://source.denx.de/u-boot/u-boot/-/issues/42).
I'd like to discuss here if this is a proper solution to the issue or if
there is a better proposal. Since this is my first contribution, I have
barely an overview of the u-boot internals.
Please give also hints regarding any wording or explanations in the
commit message.
Signed-off-by: Jonas Jelonek <jelonek.jo...@gmail.com>
Cc: Tom Rini <tr...@konsulko.com>
---
Jonas Jelonek (1):
arm: provide noncached_set_region prototype to fix build
arch/arm/include/asm/system.h | 1 +
cmd/cache.c | 1 +
2 files changed, 2 insertions(+)
--
2.39.5 (Apple Git-154)
