On Wed, May 04, 2011 at 10:04:42AM +0200, Stefano Babic wrote: > On 05/04/2011 08:13 AM, Shawn Guo wrote: > > With the following commit, CONFIG_OF_LIBFDT is redefined. > > > > 2fa8ca98c37d5b1bb0328b19ddb7e9d162cd9683 > > Add CONFIG_OF_LIBFDT to more boards. > > > > Remove the duplicated definition to fix CONFIG_OF_LIBFDT redefined > > warning. > > > > Signed-off-by: Shawn Guo <shawn....@linaro.org> > > Hi Shawn, > > > --- > > include/configs/mx51evk.h | 2 -- > > include/configs/mx53evk.h | 2 -- > > 2 files changed, 0 insertions(+), 4 deletions(-) > > > > diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h > > index febe8d8..207b20c 100644 > > --- a/include/configs/mx51evk.h > > +++ b/include/configs/mx51evk.h > > @@ -226,6 +226,4 @@ > > #define CONFIG_ENV_IS_IN_MMC > > #define CONFIG_SYS_MMC_ENV_DEV 0 > > > > -#define CONFIG_OF_LIBFDT > > Thanks to clean up this. Could you also drop the not needed "1" to the > other define ? > > #define CONFIG_OF_LIBFDT 1 > > Should be: > #define CONFIG_OF_LIBFDT > As you can see from the commit below,
2fa8ca98c37d5b1bb0328b19ddb7e9d162cd9683 Add CONFIG_OF_LIBFDT to more boards. CONFIG_OF_LIBFDT was defined with '1' in all those files. --- include/configs/ca9x4_ct_vxp.h | 2 ++ include/configs/devkit8000.h | 2 ++ include/configs/efikamx.h | 2 ++ include/configs/igep0020.h | 2 ++ include/configs/igep0030.h | 2 ++ include/configs/mx51evk.h | 2 ++ include/configs/mx53evk.h | 2 ++ include/configs/omap3_overo.h | 2 ++ include/configs/omap3_pandora.h | 2 ++ include/configs/omap3_sdp3430.h | 2 ++ include/configs/omap3_zoom1.h | 2 ++ include/configs/omap3_zoom2.h | 2 ++ include/configs/omap4_panda.h | 2 ++ include/configs/omap4_sdp4430.h | 2 ++ include/configs/tegra2-common.h | 1 + 15 files changed, 29 insertions(+), 0 deletions(-) If you really want to get this '1' removed, I would prefer to do it globally with another patch. -- Regards, Shawn _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
