On Thu, Oct 10, 2024 at 12:39:09PM +0530, Neha Malcom Francis wrote:

> The message "DRAM:  2 GiB (effective 32 GiB)" can be a little confusing,
> modify the message to show exactly what is meant:
> 
> "DRAM:  2 GiB (available for U-Boot out of total 32 GiB)"
> 
> Signed-off-by: Neha Malcom Francis <n-fran...@ti.com>
> ---
>  common/board_f.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/board_f.c b/common/board_f.c
> index 154675d0e40..b7add8f7d3d 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -254,7 +254,7 @@ static int show_dram_config(void)
>  
>       print_size(gd->ram_size, "");
>       if (!sizes_near(gd->ram_size, size)) {
> -             printf(" (effective ");
> +             printf(" (available for U-Boot out of total ");
>               print_size(size, ")");
>       }
>       board_add_ram_info(0);

We're growing a constant string in every build here. I would rather see 
doc/develop/memory.rst start to get updated to spell out that when we
print "effective" here it's because we do not have the full 64bit
address space available, only 2GiB.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to