Tom On Fri, 4 Oct 2024 at 21:30, Tom Rini <tr...@konsulko.com> wrote: > > On Thu, Oct 03, 2024 at 05:22:46PM +0200, Jerome Forissier wrote: > > > This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip > > library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP > > stack [2] [3] as an alternative to the current implementation in net/, > > selectable with Kconfig, and ultimately keep only lwIP if possible. Some > > reasons for doing so are: > > - Make the support of HTTPS in the wget command easier. Javier T. and > > Raymond M. (CC'd) have some additional lwIP and Mbed TLS patches to do > > so. With that it becomes possible to fetch and launch a distro installer > > such as Debian etc. using a secure, authenticated connection directly > > from the U-Boot shell. Several use cases: > > * Authentication: prevent MITM attack (third party replacing the > > binary with a different one) > > * Confidentiality: prevent third parties from grabbing a copy of the > > image as it is being downloaded > > * Allow connection to servers that do not support plain HTTP anymore > > (this is becoming more and more common on the Internet these days) > > - Possibly benefit from additional features implemented in lwIP > > - Less code to maintain in U-Boot > > > > Prior to applying this series, the lwIP stack needs to be added as a > > Git subtree with the following command: > > > > $ git subtree add --squash --prefix lib/lwip/lwip \ > > https://github.com/lwip-tcpip/lwip.git STABLE-2_2_0_RELEASE > > So, assuming the outstanding questions raised on v11 are easy enough to > resolve, I think v12 should be posted with being merged in mind (and so > no TESTING patches, etc, since I'll "b4 shazam -SM" it. Thanks for > working on this so hard!
FWIW I am generally happy with the whole series. Unfortunately I dont have time to do a full detailed review, but we've fixed enough to be confident it's 'ok' to pull. I think we'll improve it faster over time once people start using it Thanks /Ilias > > -- > Tom
