Dear Simon Guinot, In message <1304262244-13788-7-git-send-email-simon.gui...@sequanux.org> you wrote: > From: Simon Guinot <sgui...@lacie.com> > > This patch add support for the Network Space v2 board and parents. > This include Network Space (Max) v2 and Internet Space v2. > > Signed-off-by: Simon Guinot <sgui...@lacie.com> > --- > Makefile | 7 ++ > board/LaCie/netspace_v2/Makefile | 49 ++++++++++ > board/LaCie/netspace_v2/kwbimage.cfg | 162 > +++++++++++++++++++++++++++++++++ > board/LaCie/netspace_v2/netspace_v2.c | 150 ++++++++++++++++++++++++++++++ > board/LaCie/netspace_v2/netspace_v2.h | 39 ++++++++ > include/configs/netspace_v2.h | 142 +++++++++++++++++++++++++++++ > 6 files changed, 549 insertions(+), 0 deletions(-) > create mode 100644 board/LaCie/netspace_v2/Makefile > create mode 100644 board/LaCie/netspace_v2/kwbimage.cfg > create mode 100644 board/LaCie/netspace_v2/netspace_v2.c > create mode 100644 board/LaCie/netspace_v2/netspace_v2.h > create mode 100644 include/configs/netspace_v2.h
Entries to MAINTAINERS file missing. > diff --git a/Makefile b/Makefile > index ada951e..18e6ecd 100644 > --- a/Makefile > +++ b/Makefile > @@ -897,6 +897,13 @@ TNY_A9260_config : unconfig > @echo "#define CONFIG_$(@:_config=) 1" >$(obj)include/config.h > @$(MKCONFIG) -n $@ -a tny_a9260 arm arm926ejs tny_a9260 calao at91 > > +inetspace_v2_config \ > +netspace_v2_config \ > +netspace_max_v2_config : unconfig > + @mkdir -p $(obj)include > + @echo "#define CONFIG_$(shell echo $(@:_config=) | tr 'a-z' 'A-Z') 1" > >$(obj)include/config.h > + @$(MKCONFIG) -n $@ -a netspace_v2 arm arm926ejs netspace_v2 LaCie > kirkwood NAK. We don't add boards to Makefile any more. Please add entries to boards.cfg instead. > +int board_init(void) > +{ > + /* Board arch number */ > +#if defined(CONFIG_NETSPACE_V2) > + gd->bd->bi_arch_number = MACH_TYPE_NETSPACE_V2; > +#elif defined(CONFIG_INETSPACE_V2) > + gd->bd->bi_arch_number = MACH_TYPE_INETSPACE_V2; > +#elif defined(CONFIG_NETSPACE_MAX_V2) > + gd->bd->bi_arch_number = MACH_TYPE_NETSPACE_MAX_V2; > +#endif Please get rid of the #ifdef's here and define the MACH_TYPE in your board config file. ... > +void mv_phy_88e1116_init(char *name) > +{ ... > + printf("88E1116 Initialized on %s\n", name); Maybe you want to change this into a debug() instead? [I guess it corrupts the formatting of the boot messages?] ... > +#define CONFIG_SYS_HZ 800 NAK. CONFIG_SYS_HZ must always be 1000. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There are no data that cannot be plotted on a straight line if the axis are chosen correctly. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot