Hi Mike,
> On Wed, Apr 27, 2011 at 11:25, Detlev Zundel wrote:
>> Now that we have the documentation, the code should be changed to reflect
>> it ;)
>>
>> Asd far as I can see, these are the places where HW_WATCHDOG is used
>> instead of WATCHDOG:
>
> the trouble is that watchdog.h doesnt seem to match, nor does the
> name. "hardware" means to me "hardware" as in "the cpu hardware".
Yes, I understand that the situation is not 100% ideal, but I do not
share your pessimism. Currently we should straighten out the
inconsistencies present in the code and then subsequently we can think
about aligning it with what we agree on to be a good name for.
>
> #ifdef CONFIG_HW_WATCHDOG
> ...
> #else
> /*
> * Maybe a software watchdog?
> */
> ...
> #endif
>
> i dont see how a watchdog in the SoC could be a "software" watchdog or
> a "non-hardware" watchdog.
True, we should align the comments in here also - I'll se if I can come
up with something sensible.
> the watchdog system is a legacy mess, so probably be easier to just
> gut the whole thing.
A agree that the naming is not ideal, but this isn't a good enough
argument for removing it. Apart from that, this feature is used in many
commercial systems...
Cheers
Detlev
--
config LGUEST
If unsure, say N. If curious, say M. If masochistic, say Y.
-- linux/drivers/lguest/Kconfig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
