On Wed, Aug 21, 2024 at 08:29:07PM +0530, Siddharth Vadapalli wrote: > Add support for the Cadence PCIe Controller present on TI's K3 SoCs. > This driver is an adaptation of the Linux driver. > > Signed-off-by: Siddharth Vadapalli <s-vadapa...@ti.com> [snip] > diff --git a/drivers/pci/pcie_cdns_ti.c b/drivers/pci/pcie_cdns_ti.c > new file mode 100644 > index 0000000000..2b9bba19b4 > --- /dev/null > +++ b/drivers/pci/pcie_cdns_ti.c > @@ -0,0 +1,645 @@ > +// SPDX-License-Identifier: GPL-2.0-only OR MIT > +/* > + * Copyright (C) 2024 Texas Instruments Incorporated - https://www.ti.com > + * > + * PCIe controller driver for TI's K3 SoCs with Cadence PCIe controller > + * > + * Ported from the Linux driver - drivers/pci/controller/cadence/pci-j721e.c > + * > + * Author: Siddharth Vadapalli <s-vadapa...@ti.com> > + * > + */ > + > +#include <asm/global_data.h> > +#include <asm/gpio.h> > +#include <clk-uclass.h> > +#include <dm.h> > +#include <dm/device_compat.h> > +#include <generic-phy.h> > +#include <linux/bitops.h> > +#include <linux/delay.h> > +#include <linux/err.h> > +#include <linux/io.h> > +#include <linux/log2.h> > +#include <log.h> > +#include <pci.h> > +#include <power-domain.h> > +#include <regmap.h> > +#include <syscon.h>
Please audit this list to make sure you need everything because.. > + > +DECLARE_GLOBAL_DATA_PTR; You don't reference gd in this code at all, so don't need this. So please also make sure the giant list of defines is needed. > +#define usleep_range(a, b) udelay((b)) Per checkpatch.pl.conf: # Not Linux, so we don't recommend usleep_range() over udelay() -- Tom
signature.asc
Description: PGP signature
