Dear Roy Zang, In message <1300161222-19050-1-git-send-email-tie-fei.z...@freescale.com> you wrote: > This patch enables compiler debug option for powerpc platforms > by default. Patch is tested on 85xx/QorIQ platforms in u-boot > with CodeWarrior. > > Signed-off-by: Roy Zang <tie-fei.z...@freescale.com> > Cc: Wood Scott-B07421 <b07...@freescale.com> > Cc: Kumar Gala <ga...@kernel.crashing.org> > --- > Consider the comments > http://lists.denx.de/pipermail/u-boot/2010-October/080689.html > http://lists.denx.de/pipermail/u-boot/2011-January/086485.html
Indeed. In http://lists.denx.de/pipermail/u-boot/2011-January/086485.html I wrote: | I don't see where this is specific to the Power architecture either - | expect that you only tested it there. | | My understanding is that you enable debug settings for the GNU | debugger. | | Do these need to be architecture specific? Probably not. | | Do these need to be enabled by a new #define? What would be the | disadvantages of having these options always enabled, for all | architectures? You did not comment to these questions, and your current code is still powerpc-centric. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Schshschshchsch. -- The Gorn, "Arena", stardate 3046.2 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
