Hi Michal, On Thu, 25 Jul 2024 at 00:14, Michal Simek <michal.si...@amd.com> wrote: > > > > On 7/24/24 22:54, Tom Rini wrote: > > On Wed, Jul 24, 2024 at 11:31:48AM +0530, Sughosh Ganu wrote: > > > >> From: Simon Glass <s...@chromium.org> > >> > >> Use this new data structure in the utility function. > >> > >> Signed-off-by: Simon Glass <s...@chromium.org> > >> Signed-off-by: Sughosh Ganu <sughosh.g...@linaro.org> > >> --- > >> lib/strto.c | 35 +++++++++++++++++++---------------- > >> 1 file changed, 19 insertions(+), 16 deletions(-) > > > > This is rather big growth when we didn't already have realloc: > > 05: lib: Convert str_to_list() to use alist > > aarch64: (for 1/1 boards) all +1765.0 rodata +37.0 text +1728.0 > > xilinx_versal_mini_emmc0: all +1765 rodata +37 text +1728 > > u-boot: add: 7/0, grow: 1/0 bytes: 1728/0 (1728) > > function old new > > delta > > realloc - 1120 > > +1120 > > alist_ensure_ptr - 140 > > +140 > > alist_expand_to - 136 > > +136 > > alist_init - 108 > > +108 > > alist_uninit_move_ptr - 76 > > +76 > > alist_add_ptr - 72 > > +72 > > alist_uninit - 48 > > +48 > > str_to_list 204 232 > > +28 > > > > this is definitely not acceptable. This mini configuration is running out of > OCM > and we are already pretty close to limit.
Also I forgot to mention that mx6sabresd exceeds its limit with this patch. > > What's the reason for this change? I can't see any explanation in commit > message. Much like the abuf library (which initially had no users), I try to avoid adding dead code. So some sort of example is helpful. The bug that I found in str_to_list() was fixed in the earlier commit in the series, without needing alist. so it isn't necessary for that. Regards, Simon
