On Friday, April 15, 2011 04:25:58 Macpaul Lin wrote:
> 2011/4/15 Mike Frysinger:
> > On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote:
> >>  #if !defined(CONFIG_ENV_IS_IN_EEPROM)        && \
> >> -    !defined(CONFIG_ENV_IS_IN_FLASH) && \
> >> +     !defined(CONFIG_ENV_IS_IN_FLASH)        && \
> > 
> > not sure this one hunk is desirable, but the rest are fine
> > -mike
> 
> Do you mean the replacement with space to ident?
> 
> According to the 2.6.38.1's checkpatch, it reported:
> WARNING: please, no spaces at the start of a line

this particular check has already been posted upstream as generally causing 
more harm than good.  but getting checkpatch fixed often feels glacial.

up to Wolfgang how he feels about ifdef indentation
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to