Dear Chander Kashyap, On 14 April 2011 18:17, Chander Kashyap <chander.kash...@linaro.org> wrote: > Macro values for Pull Up and Driver Strength were wrong. > > Signed-off-by: Chander Kashyap <chander.kash...@linaro.org> > --- > arch/arm/include/asm/arch-s5pc2xx/gpio.h | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/include/asm/arch-s5pc2xx/gpio.h > b/arch/arm/include/asm/arch-s5pc2xx/gpio.h > index 05e5b3e..7bfa8e8 100644 > --- a/arch/arm/include/asm/arch-s5pc2xx/gpio.h > +++ b/arch/arm/include/asm/arch-s5pc2xx/gpio.h > @@ -99,12 +99,12 @@ void gpio_set_rate(struct s5p_gpio_bank *bank, int gpio, > int mode); > /* Pull mode */ > #define GPIO_PULL_NONE 0x0 > #define GPIO_PULL_DOWN 0x1 > -#define GPIO_PULL_UP 0x2 > +#define GPIO_PULL_UP 0x3 > > /* Drive Strength level */ > #define GPIO_DRV_1X 0x0 > -#define GPIO_DRV_2X 0x1 > -#define GPIO_DRV_3X 0x2 > +#define GPIO_DRV_2X 0x2 > +#define GPIO_DRV_3X 0x1
Please make orders correctly (0x0, 0x1, 0x2, 0x3) > #define GPIO_DRV_4X 0x3 > #define GPIO_DRV_FAST 0x0 > #define GPIO_DRV_SLOW 0x1 Nice catch : ) Could please fix s5pc1xx also? Please make it one patch. Thanks. Minkyu Kang. -- from. prom. www.promsoft.net _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
