On Wed, Mar 06, 2024 at 09:50:06AM +0100, Heinrich Schuchardt wrote:
> On 3/5/24 16:16, Dan Carpenter wrote:
> > Select CONFIG_64BIT so that we pass the -m64 option (instead of -m32) to
> > static analysis tools.
> >
> > Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
> > ---
> > arch/sandbox/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/sandbox/Kconfig b/arch/sandbox/Kconfig
> > index 0ce77de2fcb4..c431da60e8c4 100644
> > --- a/arch/sandbox/Kconfig
> > +++ b/arch/sandbox/Kconfig
> > @@ -12,6 +12,7 @@ config SYS_CPU
> >
> > config SANDBOX64
> > bool "Use 64-bit addresses"
> > + select 64BIT
>
> SANDBOX64 seems only to control the size of phys_addr_t, phys_size_t,
> dma_addr_t.
Heh. I assumed SANDBOX64 was much more important than it was...
>
> Please, have a look at symbol SANDBOX_BITS_PER_LONG. It is controlled by
> HOST_64BIT, not by SANDBOX64. Isn't this closer related to the -m32/-m64
> choice?
What about if I just did something like this. It seems to work okay.
regards,
dan carpenter
diff --git a/arch/sandbox/Kconfig b/arch/sandbox/Kconfig
index 0ce77de2fcb4..ebffad32e94f 100644
--- a/arch/sandbox/Kconfig
+++ b/arch/sandbox/Kconfig
@@ -46,6 +46,7 @@ config HOST_32BIT
config HOST_64BIT
def_bool $(cc-define,_LP64)
+ select 64BIT
config HOST_HAS_SDL
def_bool $(success,sdl2-config --version)
