Hi, Tom,
Q:
> + model = "AST2600 ASUS";
> + compatible = "aspeed,ast2600-asus", "aspeed,ast2600";
A: I do a modification, replace "ast2600-evb" with "ast2600-asus".
Q: All of these are bootph* now.
And is there effort being made to upstream the dts files for these platforms to
Linux?
A: Yes, I also git send-email to kernel related persons to add a asus dts in
kernel device tree.
My typo, I would like to correct it.
> @@ -0,0 +1,239 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +// Copyright 2023 ASUS Corp.
Thans for review.
Best Regards
Kelly
-----Original Message-----
From: Tom Rini <tr...@konsulko.com>
Sent: Tuesday, January 30, 2024 11:09 PM
To: Kelly Hung <ppigho...@gmail.com>
Cc: u-boot@lists.denx.de; open...@lists.ozlabs.org; Kelly Hung(洪嘉莉)
<kelly_h...@asus.com>
Subject: Re: [PATCH] dts: ast2600: add x4tf dts for asus product
On Tue, Jan 30, 2024 at 06:40:45PM +0800, Kelly Hung wrote:
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: Kelly Hung <kelly_h...@asus.com>
> ---
> arch/arm/dts/Makefile | 3 +-
> arch/arm/dts/ast2600-x4tf.dts | 239
> ++++++++++++++++++++++++++++++++++
[snip]
> diff --git a/arch/arm/dts/ast2600-x4tf.dts
> b/arch/arm/dts/ast2600-x4tf.dts new file mode 100644 index
> 00000000..3c478058
> --- /dev/null
> +++ b/arch/arm/dts/ast2600-x4tf.dts
> @@ -0,0 +1,239 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +// Copyright 2020 IBM Corp.
> +/dts-v1/;
> +
> +#include "ast2600-u-boot.dtsi"
> +
> +/ {
> + model = "AST2600 ASUS";
> + compatible = "aspeed,ast2600-evb", "aspeed,ast2600";
Compatible should be board unique.
> +&uart5 {
> + u-boot,dm-pre-reloc;
All of these are bootph* now.
And is there effort being made to upstream the dts files for these platforms to
Linux?
--
Tom
===================================================================================================================================
This email and any attachments to it contain confidential information and are
intended solely for the use of the individual to whom it is addressed. If you
are not the intended recipient or receive it accidentally, please immediately
notify the sender by e-mail and delete the message and any attachments from
your computer system, and destroy all hard copies. Please be advised that any
unauthorized disclosure, copying, distribution or any action taken or omitted
in reliance on this, is illegal and prohibited. Any views or opinions expressed
are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale
price. All customers are free to set their own price as they wish.
===================================================================================================================================
