Re: [PATCH v3 3/4] net: tftp: remove explicit efi configuration dependency

[Heinrich Schuchardt]

On 12/18/23 03:38, AKASHI Takahiro wrote:

Now it is clear that the feature actually depends on efi interfaces,
not "bootefi" command. efi_set_bootdev() will automatically be nullified
if necessary efi component is disabled.

Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org>
---
  net/tftp.c | 10 ++++------
  1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/net/tftp.c b/net/tftp.c
index 88e71e67de35..2e335413492b 100644
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -302,12 +302,10 @@ static void tftp_complete(void)
                        time_start * 1000, "/s");
        }
        puts("\ndone\n");
-       if (IS_ENABLED(CONFIG_CMD_BOOTEFI)) {
-               if (!tftp_put_active)
-                       efi_set_bootdev("Net", "", tftp_filename,
-                                       map_sysmem(tftp_load_addr, 0),
-                                       net_boot_file_size);
-       }
+       if (!tftp_put_active)
+               efi_set_bootdev("Net", "", tftp_filename,

Function efi_set_bootdev() will not be compiled for CONFIG_EFI_LOADER=n.
So this change may lead to build failures.

Best regards

Heinrich

+                               map_sysmem(tftp_load_addr, 0),
+                               net_boot_file_size);
        net_set_state(NETLOOP_SUCCESS);
  }