Hi AKASHI,
On Sun, 17 Dec 2023 at 19:39, AKASHI Takahiro
<takahiro.aka...@linaro.org> wrote:
>
> Now it is clear that the feature actually depends on efi interfaces,
> not "bootefi" command. efi_set_bootdev() will automatically be nullified
> if necessary efi component is disabled.
>
> Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org>
> ---
> net/tftp.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
I have the same comment here as the 'fs' patch.
> diff --git a/net/tftp.c b/net/tftp.c
> index 88e71e67de35..2e335413492b 100644
> --- a/net/tftp.c
> +++ b/net/tftp.c
> @@ -302,12 +302,10 @@ static void tftp_complete(void)
> time_start * 1000, "/s");
> }
> puts("\ndone\n");
> - if (IS_ENABLED(CONFIG_CMD_BOOTEFI)) {
Shouldn't this depend on your new CONFIG? What happens if EFI_LOADER
is not enabled?
> - if (!tftp_put_active)
> - efi_set_bootdev("Net", "", tftp_filename,
> - map_sysmem(tftp_load_addr, 0),
> - net_boot_file_size);
> - }
> + if (!tftp_put_active)
> + efi_set_bootdev("Net", "", tftp_filename,
> + map_sysmem(tftp_load_addr, 0),
> + net_boot_file_size);
> net_set_state(NETLOOP_SUCCESS);
> }
>
> --
> 2.34.1
>
Regards,
Simon
