Dear Lei Wen, In message <1301292225-15069-1-git-send-email-lei...@marvell.com> you wrote: > Those api take use of read*/write* to align the current dmb usage. > Also this could short the code length in one line. > > Signed-off-by: Lei Wen <lei...@marvell.com> > --- > Changelog: > V4.1 > fix code style issue
That should be V4.1 (or better V5) in the Subject then, too. Please also note that all your patches are missing a correct changelog. 1/6 has no changelog at all. 2/6 fails to document the v4 changes 3/6 shows only V3 changes 4/6 ditto 5/6 ditto 6/6 ditto This is not acceptable. I do not intend to read and compare ll the previous versions, so I refuse to review this. You may consider this a NAK to the whole patch series. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Though a program be but three lines long, someday it will have to be maintained." - The Tao of Programming _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
