On 12-18 23:32, Stefan Wahren wrote:
> >
> > static const struct udevice_id bcm2835_video_ids[] = {
> > - { .compatible = "brcm,bcm2835-hdmi" },
> > - { .compatible = "brcm,bcm2711-hdmi0" },
> > - { .compatible = "brcm,bcm2708-fb" },
> > + { .compatible = "brcm,bcm2835-hdmi", .data = VIDEO_BPP32},
> > + { .compatible = "brcm,bcm2711-hdmi0", .data = VIDEO_BPP32},
> > + { .compatible = "brcm,bcm2708-fb", .data = VIDEO_BPP16 },
> this change looks wrong to me. Before we used VIDEO_BPP32 for
> brcm,bcm2708-fb. I think it's hard to explain why we should downgrade
> the other boards. I would expect some brcm,bcm2712 compatible at least
> this needs an explanation in the commit message.
>
If you are confident that this semi device was working before with
BPP32 I will try to find better way to handle this. Do you remember
which RPi version was this?
Thanks,
Ivan
