Hi Heinrich, On Sat, 16 Dec 2023 at 12:21, Heinrich Schuchardt <heinrich.schucha...@canonical.com> wrote: > > On 12/16/23 19:45, Simon Glass wrote: > > On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt > > <heinrich.schucha...@canonical.com> wrote: > >> > >> Use X_DSDT and X_FIRMWARE_CTRL if available. > >> > >> Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com> > >> --- > >> lib/acpi/acpi.c | 29 ++++++++++++++++++++++++----- > >> 1 file changed, 24 insertions(+), 5 deletions(-) > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > This could really use a test > > I guess we want a test on library level separate from test/dm/acpi.c as > this test will not be driver model related?
Yes, but it isn't that important. I have been moving DM tests to only differ in their flags, so I'm not sure there is much difference anymore. Regards, Simon
