Hi Tom,
On Mon, 11 Dec 2023 at 13:53, Tom Rini <tr...@konsulko.com> wrote:
>
> On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
> > Hi,
> >
> > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore <i...@shantur.com> wrote:
> > >
> > > Add smbios information for Pine64 RockPro64 board and enable in
> > > config
> > >
> > > Signed-off-by: Shantur Rathore <i...@shantur.com>
> > > ---
> > > Changes
> > > v4: Change PINE64 to Pine64
> > > v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > >
> > > arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> > > configs/rockpro64-rk3399_defconfig | 2 ++
> > > 2 files changed, 24 insertions(+)
> > >
> > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > index 732727d9b0..089732524a 100644
> > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > @@ -9,6 +9,28 @@
> > > chosen {
> > > u-boot,spl-boot-order = "same-as-spl", &spi_flash,
> > > &sdmmc, &sdhci;
> > > };
> > > +
> > > + smbios {
> > > + compatible = "u-boot,sysinfo-smbios";
> > > + smbios {
> > > + system {
> > > + manufacturer = "Pine64";
> > > + product = "RockPro64";
> > > + };
> > > +
> > > + baseboard {
> > > + manufacturer = "Pine64";
> > > + product = "RockPro64";
> > > + };
> > > +
> > > + chassis {
> > > + manufacturer = "Pine64";
> > > + product = "RockPro64";
> > > + };
> > > + };
> > > + };
> > > +
> > > +
> > > };
> > >
> > > &sdhci {
> > > diff --git a/configs/rockpro64-rk3399_defconfig
> > > b/configs/rockpro64-rk3399_defconfig
> > > index 4cd6b76665..affb6137e0 100644
> > > --- a/configs/rockpro64-rk3399_defconfig
> > > +++ b/configs/rockpro64-rk3399_defconfig
> > > @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000
> > > CONFIG_DEBUG_UART_SHIFT=2
> > > CONFIG_SYS_NS16550_MEM32=y
> > > CONFIG_ROCKCHIP_SPI=y
> > > +CONFIG_SYSINFO=y
> > > +CONFIG_SYSINFO_SMBIOS=y
> > > CONFIG_SYSRESET=y
> > > CONFIG_USB=y
> > > CONFIG_USB_XHCI_HCD=y
> > > --
> > > 2.40.1
> > >
> >
> > Can this please be merged if no changes are required?
> >
> > [0] -
> > https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-...@shantur.com/
>
> Yes, we should just defer this and pickup the SMBIOS series that Ilias
> has posted.
I don't think it is a suitable substitute, it is just a fallback.
So I believe this patch should be applied.
Reviewed-by: Simon Glass <s...@chromium.org>
Regards,
Simon
