On Tue, Oct 17, 2023 at 09:31:29PM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 17 Oct 2023 at 08:07, Tom Rini <tr...@konsulko.com> wrote: > > > > On Mon, Oct 16, 2023 at 04:28:10PM -0600, Simon Glass wrote: > > > While it is nice to have the font command, using 'select' makes it > > > impossible to build the console code without it. Change this to use > > > 'imply' instead. > > > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > > --- > > > > > > (no changes since v1) > > > > > > drivers/video/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > > > index ab927641bb7a..21ea5c860cca 100644 > > > --- a/drivers/video/Kconfig > > > +++ b/drivers/video/Kconfig > > > @@ -180,7 +180,7 @@ config CONSOLE_ROTATION > > > > > > config CONSOLE_TRUETYPE > > > bool "Support a console that uses TrueType fonts" > > > - select CMD_SELECT_FONT > > > + imply CMD_SELECT_FONT > > > help > > > TrueTrype fonts can provide outline-drawing capability rather than > > > needing to provide a bitmap for each font and size that is needed. > > > > This is one of those cases where "if CMDLINE" makes sense to add > > somewhere. > > Maybe, if you can explain it a bit more. I want boards to be able to > enable or disable this command, independently of whether truetype > fonts are supported. Using 'select' here seems quite inflexible.
Ah, OK. Checking the command itself, we should drop the select here and make CMD_SELECT_FONT default y if CONSOLE_TRUETYPE (and drop the default n line it has). -- Tom
signature.asc
Description: PGP signature
