On Tue, Oct 17, 2023 at 09:31:22PM -0600, Simon Glass wrote:
> Hi Tom,
>
> On Tue, 17 Oct 2023 at 08:07, Tom Rini <tr...@konsulko.com> wrote:
> >
> > On Mon, Oct 16, 2023 at 04:28:09PM -0600, Simon Glass wrote:
> >
> > > Provide a fallback for when CONFIG_SYS_CBSIZE is not provided, so that
> > > the console can still be used.
> > >
> > > Signed-off-by: Simon Glass <s...@chromium.org>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > > drivers/video/console_truetype.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/video/console_truetype.c
> > > b/drivers/video/console_truetype.c
> > > index 14fb81e9563c..e4dad3f9a191 100644
> > > --- a/drivers/video/console_truetype.c
> > > +++ b/drivers/video/console_truetype.c
> > > @@ -125,7 +125,11 @@ struct pos_info {
> > > * Allow one for each character on the command line plus one for each
> > > newline.
> > > * This is just an estimate, but it should not be exceeded.
> > > */
> > > +#ifdef CONFIG_SYS_CBSIZE
> > > #define POS_HISTORY_SIZE (CONFIG_SYS_CBSIZE * 11 / 10)
> > > +#else
> > > +#define POS_HISTORY_SIZE (250 * 11 / 10)
> > > +#endif
> > >
> > > /**
> > > * struct console_tt_metrics - Information about a font / size
> > > combination
> >
> > NAK, this either should be SYS_PBSIZE (output buffer) instead which you
> > move out from under CMDLINE or SYS_CBSIZE (input buffer) should also be
> > outside, and both get a help text to explain them a bit better.
>
> I think PBSIZE would be better. Even better (eventually) will be to
> drop this truetype buffer if input is not needed.Then lets switch this to PBSIZE. -- Tom
signature.asc
Description: PGP signature
