Hi Tom, On Tue, Oct 17, 2023, 07:13 Tom Rini <tr...@konsulko.com> wrote: > > On Mon, Oct 16, 2023 at 04:28:12PM -0600, Simon Glass wrote: > > The command should not be used to enable library functionality. Add a > > new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the > > same code is built. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > Suggested-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > [snip] > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > > index 621ed5e5b0fb..13cad6342c36 100644 > > --- a/lib/efi_loader/Kconfig > > +++ b/lib/efi_loader/Kconfig > > @@ -32,15 +32,14 @@ config EFI_LOADER > > > > if EFI_LOADER > > > > -config CMD_BOOTEFI_BOOTMGR > > +config BOOTEFI_BOOTMGR > > bool "UEFI Boot Manager" > > - depends on CMDLINE > > This is another example of why I'm asking for re-ordering things so that > first you clean / re-order things then you make all of CMD depend on > CMDLINE. This patch, aside from other feedback, is standalone, if you > do that.
This patch is before the one that makes all of CMD depend on CMDLINE. Regards, Simon
