On 14:45-20230505, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.r...@ti.com>
>
> Pin-mux nodes should not be present in the R5 dts file; instead, they
> should be inherited from the board dts file. To enable/override the
> appropriate configurations, remove the pinmux nodes from am68-sk-r5 dts
> and inherit the nodes from board dts.
>
> Signed-off-by: Sinthu Raja <sinthu.r...@ti.com>
> ---
> arch/arm/dts/k3-am68-sk-base-board.dts | 18 +++++++
> arch/arm/dts/k3-am68-sk-r5-base-board.dts | 63 +----------------------
> 2 files changed, 20 insertions(+), 61 deletions(-)
>
Thanks for doing this, BUT:
> diff --git a/arch/arm/dts/k3-am68-sk-base-board.dts
> b/arch/arm/dts/k3-am68-sk-base-board.dts
> index 8fc03324ab..df45be1a83 100644
> --- a/arch/arm/dts/k3-am68-sk-base-board.dts
> +++ b/arch/arm/dts/k3-am68-sk-base-board.dts
> @@ -136,6 +136,24 @@
> J721S2_WKUP_IOPAD(0x098, PIN_INPUT, 0) /* (A22)
> MCU_MDIO0_MDIO */
> >;
> };
> +
> + mcu_uart0_pins_default: mcu-uart0-pins-default {
> + bootph-pre-ram;
> + pinctrl-single,pins = <
> + J721S2_WKUP_IOPAD(0x0f4, PIN_INPUT, 0) /*(C24)
> WKUP_GPIO0_13.MCU_UART0_RXD*/
> + J721S2_WKUP_IOPAD(0x0f0, PIN_OUTPUT, 0) /*(C25)
> WKUP_GPIO0_12.MCU_UART0_TXD*/
> + >;
> + };
> +
> + wkup_uart0_pins_default: wkup-uart0-pins-default {
> + bootph-pre-ram;
> + pinctrl-single,pins = <
> + J721S2_WKUP_IOPAD(0x0d8, PIN_INPUT, 0) /*(E25)
> WKUP_GPIO0_6.WKUP_UART0_CTSn*/
> + J721S2_WKUP_IOPAD(0x0dc, PIN_OUTPUT, 0) /*(F28)
> WKUP_GPIO0_7.WKUP_UART0_RTSn*/
> + J721S2_WKUP_IOPAD(0x0b0, PIN_INPUT, 0) /* (D28)
> WKUP_UART0_RXD */
> + J721S2_WKUP_IOPAD(0x0b4, PIN_OUTPUT, 0) /* (D27)
> WKUP_UART0_TXD */
> + >;
> + };
NAK, not on k.org master. Send and get accepted in upstream k.org, then we
will pick it up as part of kernel migration.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
