Hi Mittelstaedt, On Wed, 3 May 2023 at 23:40, Mittelstaedt Thomas (XC-CT/EBV3) <thomas.mittelsta...@de.bosch.com> wrote: > > Hello Simon, > > I've tried out successfully the option (with BOOTSTD_FULL, with > BOOTSTD_DEFAULT it's not possible to boot) and will provide a changed patch > set soon. >
Thank you for testing. What goes wrong without BOOTSTD_FULL? Regards, Simon > > > Mit freundlichen Grüßen / Best regards > > Thomas Mittelstaedt > > Cross-Domain Computing Solutions > > > > -----Ursprüngliche Nachricht----- > > Von: Simon Glass <s...@chromium.org> > > Gesendet: Dienstag, 2. Mai 2023 19:12 > > An: Heinrich Schuchardt <xypron.g...@gmx.de> > > Cc: Mittelstaedt Thomas (XC-CT/EBV3) <thomas.mittelsta...@de.bosch.com>; > > u-boot@lists.denx.de; Niel Armstrong <neil.armstr...@linaro.org>; Patrick > > Delaunay <patrick.delau...@foss.st.com>; Ramon Fried > > <rfried....@gmail.com>; Marek Vasut <ma...@denx.de>; Manuel Traut > > <manuel.tr...@mt.com>; Bin Meng <bmeng...@gmail.com> > > Betreff: Re: [PATCH v2 2/3] X86: Add support for distro boot > > > > Hi, > > > > On Tue, 2 May 2023 at 09:41, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > > > > > > > > > > > Am 2. Mai 2023 17:21:29 MESZ schrieb thomas.mittelsta...@de.bosch.com: > > > >From: Thomas Mittelstaedt <thomas.mittelsta...@de.bosch.com> > > > > > > > >Enable distro boot feature for U-Boot at VirtualBox described at > > > >https://sou/ > > > >rce.denx.de%2Fu-boot%2Fu-boot%2F- > > %2Fblob%2Fmaster%2Fdoc%2Fdevelop%2Fd > > > > > >istro.rst&data=05%7C01%7Cthomas.mittelstaedt%40de.bosch.com%7Ca52180e > > > > > >e6e8f4087da4d08db4b306953%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0% > > 7C0% > > > > > >7C638186443515155378%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > > MDAiLCJQ > > > > > >IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata > > =4TSv > > > >yIZMiz4Tt7Wt36NxQR576tg%2F9cS%2FVyZS83xwN50%3D&reserved=0 > > > > > > > >Signed-off-by: Thomas Mittelstaedt <thomas.mittelsta...@bosch.com> > > > >--- > > > > configs/efi-x86_payload64_defconfig | 12 +----------- > > > > include/configs/efi-x86_payload.h | 11 +++++++++++ > > > > 2 files changed, 12 insertions(+), 11 deletions(-) > > > > > > > >diff --git a/configs/efi-x86_payload64_defconfig > > > >b/configs/efi-x86_payload64_defconfig > > > >index 30a7f31dac..a4cfe95890 100644 > > > >--- a/configs/efi-x86_payload64_defconfig > > > >+++ b/configs/efi-x86_payload64_defconfig > > > >@@ -8,33 +8,23 @@ CONFIG_TARGET_EFI_PAYLOAD=y CONFIG_FIT=y > > > >CONFIG_FIT_SIGNATURE=y CONFIG_LEGACY_IMAGE_FORMAT=y > > > >+CONFIG_DISTRO_DEFAULTS=y > > > > CONFIG_SHOW_BOOT_PROGRESS=y > > > > CONFIG_USE_BOOTARGS=y > > > > CONFIG_BOOTARGS="root=/dev/sdb3 init=/sbin/init rootwait ro" > > > >-CONFIG_USE_BOOTCOMMAND=y > > > > CONFIG_PRE_CONSOLE_BUFFER=y > > > > CONFIG_SYS_CONSOLE_INFO_QUIET=y > > > > CONFIG_DISPLAY_BOARDINFO_LATE=y > > > > CONFIG_LAST_STAGE_INIT=y > > > >-CONFIG_HUSH_PARSER=y > > > > CONFIG_SYS_PBSIZE=532 > > > > CONFIG_CMD_IDE=y > > > > CONFIG_CMD_MMC=y > > > >-CONFIG_CMD_PART=y > > > > CONFIG_CMD_USB=y > > > >-CONFIG_CMD_DHCP=y > > > > CONFIG_BOOTP_BOOTFILESIZE=y > > > > # CONFIG_CMD_NFS is not set > > > >-CONFIG_CMD_PING=y > > > > CONFIG_CMD_TIME=y > > > >-CONFIG_CMD_EXT2=y > > > >-CONFIG_CMD_EXT4=y > > > > CONFIG_CMD_EXT4_WRITE=y > > > >-CONFIG_CMD_FAT=y > > > >-CONFIG_CMD_FS_GENERIC=y > > > > CONFIG_MAC_PARTITION=y > > > >-CONFIG_ISO_PARTITION=y > > > >-CONFIG_EFI_PARTITION=y > > > > CONFIG_ENV_OVERWRITE=y > > > > CONFIG_ENV_IS_IN_FAT=y > > > > CONFIG_ENV_FAT_INTERFACE="scsi" > > > >diff --git a/include/configs/efi-x86_payload.h > > > >b/include/configs/efi-x86_payload.h > > > >index c72b067c36..e1cd8eb316 100644 > > > >--- a/include/configs/efi-x86_payload.h > > > >+++ b/include/configs/efi-x86_payload.h > > > >@@ -6,6 +6,17 @@ > > > > /* > > > > * board/config.h - configuration options, board specific > > > > */ > > > >+#ifndef CONFIG_SPL_BUILD > > > >+ > > > >+#define BOOT_TARGET_SCSI(func) \ > > > > > > Shouldn't NVMe be added here too? > > > > This is automatic if you use bootstd. > > > > > > > > Best regards > > > > > > Heinrich > > > > > > >+ func(SCSI, scsi, 0) > > > >+ > > > >+#define BOOT_TARGET_DEVICES(func) \ > > > >+ BOOT_TARGET_SCSI(func) > > > >+ > > > >+#include <config_distro_bootcmd.h> > > > >+ > > > >+#endif > > > > > > > > #ifndef __CONFIG_H > > > > #define __CONFIG_H > > > > Please can we use bootstd instead? > > > > You should just need to enable BOOTSTD_DEFAULTS and it will work. If not, > > please let me know. > > > > Please also see the various improvements in[1] available at [2]. There is > > also a > > new video driver [2]. > > > > Regards, > > Simon > > > > [1] > > https://patchwork.o/ > > zlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D351440&data=05%7C01 > > %7Cthomas.mittelstaedt%40de.bosch.com%7Ca52180ee6e8f4087da4d08db4b306 > > 953%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C6381864435151553 > > 78%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL > > CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=yjqyizWXqb > > YZmSuzfvqq4EfYvJYqXUf6irbLYhLo4qk%3D&reserved=0 > > [2] > > https://source.denx/ > > .de%2Fu-boot%2Fcustodians%2Fu-boot-dm%2F-%2Ftree%2Fbryc- > > working&data=05%7C01%7Cthomas.mittelstaedt%40de.bosch.com%7Ca52180ee > > 6e8f4087da4d08db4b306953%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C > > 0%7C638186443515155378%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA > > wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C > > %7C&sdata=5OF%2Bmc%2FVOSFFTzLp3JLrWBxvuZCfqwQDb3GzDZGlvws%3 > > D&reserved=0 > > [3] > > https://patchwork.o/ > > zlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D352929&data=05%7C01 > > %7Cthomas.mittelstaedt%40de.bosch.com%7Ca52180ee6e8f4087da4d08db4b306 > > 953%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C6381864435151553 > > 78%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL > > CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VthFwiSeQt > > 7c%2B%2F0twxRZTYu4smkJJDL18CkrST4mhiQ%3D&reserved=0