Am 26.01.2011 13:07, schrieb Albert ARIBAUD: >> --- > > IIRC, the '---' line separates patch commit message (above) from > freeform comments and history (below). Here, at least the version > history should move below the '---' line.
Wolfgang asked me that I add the numbers to the commit message. For the changelog I will investigate the git commands on how to do that best without manually editing the patch file before git send-email them. >> +- CONFIG_USE_ARCH_MEMCPY >> + CONFIG_USE_ARCH_MEMSET >> + If these options are used a optimized version of memcpy/memset will >> + be used if available. These functions may be faster under some >> + conditions but may increase the binary size. >> + > > The name of the options is not self-explaining to me. If the difference > is "generic vs arch-optimal", then maybe CONFIG_USE_ARCH_OPTIMAL_MEMxxx > would be a better name? Wolfgang didn't object on these names. If we use the OPTIMAL form it is still not clear what optimal mean. There may be a size optimized version and a speed optimized version. So we would need CONFIG_USE_ARCH_SPEED_OPTIMAL_MEMxxx which I personally dislike a lot as it is quite long. I also think that if there is an architecture specific function that it should be clear that this is optimal in some way. Thanks for review Regards Matthias _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
