On Fri, Feb 17, 2023 at 03:40:28PM +0100, Marek Vasut wrote: > On 2/17/23 15:00, Tom Rini wrote: > > On Fri, Feb 17, 2023 at 02:33:28PM +0100, Marek Vasut wrote: > > > On 2/17/23 13:50, Tom Rini wrote: > > > > When we have an arch_misc_init function, we can select it to ensure it's > > > > used. > > > > > > > > In that there is a functional change here, it's that on i.MX6 it's > > > > always been possible to populate "serial#" with something meaningful, > > > > but not every platform was taking the hook, and now it is. > > > > > > > > Signed-off-by: Tom Rini <tr...@konsulko.com> > > > > --- > > > > Cc: Marcel Ziswiler <marcel.ziswi...@toradex.com> > > > > Cc: Marek Vasut <ma...@denx.de> > > > > Cc: Olaf Mandel <o.man...@menlosystems.com> > > > > Cc: Stefano Babic <sba...@denx.de> > > > > Cc: Fabio Estevam <feste...@gmail.com> > > > > Cc: NXP i.MX U-Boot Team <uboot-...@nxp.com> > > > > > > > > Changes in v2: > > > > - Always select ARCH_MISC_INIT on IMX8M as dealing with FSL_CAAM or not > > > > needs further SoC-specific clean up work. This replaces patches 10 > > > > and > > > > 11 from before so that if the user enables FSL_CAAM then they will > > > > continue to get the functionality they had before. As Marek noted > > > > in the > > > > thread, further clean-up in this area would be good. > > > > > > The SPL code does not automatically call arch_misc_init() if > > > ARCH_MISC_INIT > > > is selected , so this won't work as-is. Is there another patch on which I > > > wasn't CCed which deals with that ? > > > > This preserves the exiting behavior, nothing more. > > Where does the arch_misc_init() get called from in SPL ? > If that remains in board code for now, then yeah, fine by me.
Yes, it's still on the board to call arch_misc_init() inside spl_board_init(). -- Tom
signature.asc
Description: PGP signature
