Hi Tom On Thu, 2023-02-16 at 13:37 +0100, Marcel Ziswiler wrote: > On Wed, 2023-02-15 at 22:36 -0500, Tom Rini wrote: > > On this platform SPL_BOARD_INIT is used to call arch_misc_init which is > > in turn empty, drop the call. > > > > Cc: Marcel Ziswiler <marcel.ziswi...@toradex.com> > > Signed-off-by: Tom Rini <tr...@konsulko.com> > > Acked-by: Marcel Ziswiler <marcel.ziswi...@toradex.com>
Sorry, I have to take my ack back. Marek (and Francesco) are, of course, right and this is indeed needed for CAAM. Please see also [1] where it got changed/introduced in/to the current form. [1] https://lore.kernel.org/all/20220919194118.105820-1-ma...@denx.de/ Cheers Marcel > > --- > > board/toradex/verdin-imx8mm/spl.c | 5 ----- > > configs/verdin-imx8mm_defconfig | 1 - > > 2 files changed, 6 deletions(-) > > > > diff --git a/board/toradex/verdin-imx8mm/spl.c > > b/board/toradex/verdin-imx8mm/spl.c > > index 9d54d60bb17d..3f33ff7d87a4 100644 > > --- a/board/toradex/verdin-imx8mm/spl.c > > +++ b/board/toradex/verdin-imx8mm/spl.c > > @@ -51,11 +51,6 @@ void spl_dram_init(void) > > ddr_init(&dram_timing); > > } > > > > -void spl_board_init(void) > > -{ > > - arch_misc_init(); > > -} > > - > > #ifdef CONFIG_SPL_LOAD_FIT > > int board_fit_config_name_match(const char *name) > > { > > diff --git a/configs/verdin-imx8mm_defconfig > > b/configs/verdin-imx8mm_defconfig > > index 5b5f7c051e54..0e7d67cf093d 100644 > > --- a/configs/verdin-imx8mm_defconfig > > +++ b/configs/verdin-imx8mm_defconfig > > @@ -40,7 +40,6 @@ CONFIG_BOARD_LATE_INIT=y > > CONFIG_SPL_HAS_BSS_LINKER_SECTION=y > > CONFIG_SPL_BSS_START_ADDR=0x910000 > > CONFIG_SPL_BSS_MAX_SIZE=0x2000 > > -CONFIG_SPL_BOARD_INIT=y > > # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set > > CONFIG_SPL_STACK=0x920000 > > CONFIG_SYS_SPL_MALLOC=y
