Hi Simon, On 2023-01-23 19:50, Simon Glass wrote: > On Sat, 21 Jan 2023 at 12:02, Jonas Karlman <jo...@kwiboo.se> wrote: >> >> In some cases it is desired for SPL to start TF-A instead of U-Boot >> proper. Add support for a new property fit,firmware that picks a >> valid entry and prepends the remaining valid entries to the >> loadables list generated by the split-elf generator. >> >> Signed-off-by: Jonas Karlman <jo...@kwiboo.se> >> --- >> v3: >> - Introduce new fit,firmware property to handle firmware selection >> v2: >> - New patch >> >> tools/binman/entries.rst | 16 +++- >> tools/binman/etype/fit.py | 62 ++++++++++-- >> tools/binman/ftest.py | 44 +++++++++ >> .../test/276_fit_firmware_loadables.dts | 96 +++++++++++++++++++ >> 4 files changed, 205 insertions(+), 13 deletions(-) >> create mode 100644 tools/binman/test/276_fit_firmware_loadables.dts > > Reviewed-by: Simon Glass <s...@chromium.org> > > I think this is a good solution. > > It does need one change, though. When using 'missing-1' this should > produce an error. We cannot silently skip things. If the > 'allow-missing' flag is enabled, then it should collect them and > report them, while continuing execution. But they cannot be ignored. > > Do you think you could fix that? It could be a follow-on patch though.
Sure, I can take a look at a follow-up patch next week. Regards, Jonas > > Reviewed-by: Simon Glass <s...@chromium.org> > > Regards, > Simon
