Original code was a nested if statement for checking 1g() and 
2g().https://github.com/TechNexion/u-boot-tn-imx/blob/tn-imx_v2021.04_5.10.72_2.2.0-stable/board/technexion/pico-imx7d/pico-imx7d_spl.c#L106Do
 you have any information about the PCB layout of the different i.MX7 pico SoM 
revisions?Question is, what is the electrical states of GPIO1_12 and GPIO1_13 
in real for these variants? My fear is that maybe one of them is not connected 
to any VDD (high) or GND (low). Question can be, what is the default logical 
state for it high or low if one of them is not connected neither to GND or VDD? 
I totaly do not understand why you need to completly refactoring the code if 
you have no posibbilites to test it with all revision of SoMs. I rather prefere 
to keep the original if statement code from Technexion, because that should 
works 100% and tested. I have no any 2GB varians SoMs yet, also i can not test 
it yet.So i am prefering more to apply my last (copy pasted from Technexion) 
patch, to support 2GB SoMs in u-boot 
mainline.https://lists.denx.de/pipermail/u-boot/2022-December/502465.html--------
 Eredeti levél --------Feladó: Fabio Estevam <feste...@gmail.com>Dátum: 2022 
december 31 17:31:01Tárgy: Re: [u-boot][master][PATCH 1/3] pico-imx7d: add 
support for 2GB memory SoMsCímzett: egyszer...@freemail.huhi Benjamin, On Sun, 
Dec 18, 2022 at 9:52 AM <egyszer...@freemail.hu> wrote: > > From: Benjamin 
Szőke <egyszer...@freemail.hu> > > Take over codes from Techenxion to support 
SoMs with 2GB DDR3. > > Signed-off-by: Benjamin Szőke <egyszer...@freemail.hu> 
> --- >  board/technexion/pico-imx7d/Makefile          |  2 +- >  
.../pico-imx7d/{spl.c => pico-imx7d_spl.c}    | 30 +++++++++++++++++-- >  2 
files changed, 28 insertions(+), 4 deletions(-) >  rename 
board/technexion/pico-imx7d/{spl.c => pico-imx7d_spl.c} (83%) Could you please 
test whether the attached patch works for you? I don't have a 2GB board variant 
here to test it myself. You also need to apply the following patch to fix the 
boot against U-Boot top of tree: 
https://lore.kernel.org/u-boot/20221231162514.334303-1-feste...@denx.de/T/#u 

Reply via email to