Hi,
+Tom Rini
On Fri, 16 Dec 2022 at 02:27, Nikita Shubin <nikita.shu...@maquefel.me> wrote:
>
> From: Nikita Shubin <n.shu...@yadro.com>
>
> Otherwise make will produce an error even with --allow-missing and
> --fake-ext-blobs set.
>
> Fixes: b38da15a054 ("binman: Use an exit code when blobs are missing")
> Signed-off-by: Nikita Shubin <n.shu...@yadro.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index de5746399a6..3fec08e7081 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1334,7 +1334,7 @@ cmd_binman = $(srctree)/tools/binman/binman $(if
> $(BINMAN_DEBUG),-D) \
> --toolpath $(objtree)/tools \
> $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \
> build -u -d u-boot.dtb -O . -m \
> - $(if $(BINMAN_ALLOW_MISSING),--allow-missing
> --fake-ext-blobs) \
> + $(if $(BINMAN_ALLOW_MISSING),--allow-missing --fake-ext-blobs
> -W) \
> -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \
> -I arch/$(ARCH)/dts -a of-list=$(CONFIG_OF_LIST) \
> $(foreach f,$(BINMAN_INDIRS),-I $(f)) \
> --
> 2.37.4
>
+Tom Rini
We do actually want to report the failure, since it means that the
image will not function. This was a recent change requested by a few
people.
Note that buildman looks for the message 'Some images are invalid' and
either returning 103, or 0 if -W is given.
There is no attempt to produce a special exit code from the Makefile.
It generally returns 2 (as per 'man make'), which is why buildman has
this extra processing.
Regards,
Simon
