Dear Reinhard Meyer, In message <4d2582f6.2040...@emk-elektronik.de> you wrote: > > >>>>>> timer_load_val -> timer_rate_hz > >>>>>> timestamp -> timer_reset_value > > I am not too happy about this "misuse" of gd->variables making them > "misnomers" and the code harder to read.
I'm not happy with this as well, and I actually will not accept the patch because of that. > timer_rate_hz is supposed to hold the rate at which the high > speed timer increments. > > timer_reset_value supposedly holds the high speed timer's value when > timer_reset() is called. > > There was a discussion started about this a while ago, but came to no > conclusion... I suggested this before: ------- Forwarded Message Date: Thu, 16 Dec 2010 15:12:41 +0100 From: Wolfgang Denk <w...@denx.de> To: Reinhard Meyer <u-b...@emk-elektronik.de> cc: U-Boot user list <u-boot@lists.denx.de>, h...@denx.de Subject: Re: [U-Boot] arm926ejs, timer: ... Maybe we should lean back and have a look at what Linux is doing in this area? The recent patch series "64-bit sched_clock" on the lak ML seems to fit pretty well :-) See http://thread.gmane.org/gmane.linux.ports.arm.kernel/99740 Can we copy from Linux? ... ------- End of Forwarded Message Unfortunately it seems nobody had time or resources to have a look yet. I think we should fix this for real now, and not continue to implement one SoC specific version or workaround after the other. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If you hear an onion ring, answer it. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
