On Sat, 2010-12-18 at 16:25 -0600, Wolfgang Denk wrote: > Dear York Sun, > > In message <1292630381-23022-2-git-send-email-york...@freescale.com> you > wrote: > > To temporarily fix buffer issue when running at flash, use bigger buffer > > to push down the stack deeper. > > > > Signed-off-by: York Sun <york...@freescale.com> > > Please explain 1) why this is needed and 2) what it has to do with > running "at" (from?) flash? > > hwconfig is intended for simple h/w configurations. In which case do > you need more than 128 characters for such settings? And is this > really needed / reasonable?
First of all, I don't need more than 128 characters for hwconfig. I think the buggy code makes the buffer less usable. If you look into the common/hwconfig.c, you will notice the _current_ code uses the stack as temporary memory to hold the variable. Even I don't agree with this way, I don't have a quick fix either. There may be two ways or more to fix it. One is to create wrapper functions to deal with pre-relocation and post-relocation functions. Another way is to allocate more space in gd. Which way do you think is better? York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
