On 9/16/22 10:32, Tom Rini wrote:
On Fri, Sep 16, 2022 at 09:11:11AM -0400, Sean Anderson wrote:
Hi Pali,
On 9/16/22 05:12, Pali Rohár wrote:
That is strange because I'm not aware of the fact that I'm riscv maintainer.
get_maintainer will pick up anyone who has touched a file recently, even in
unrelated areas. A quick git log shows that the following commits have
overlapping files with this series:
948da7773e arm: Add new config option ARCH_VERY_EARLY_INIT
1a47e6d47c crc16: Move standard CRC-16 implementation from ubifs to lib
bb3d71b7ef crc16-ccitt: Rename file with CRC-16-CCITT implementation to
crc16-ccitt.c
372779abc3 arm: Introduce new CONFIG_SPL_SYS_NO_VECTOR_TABLE option
I'm not a fan of this behavior, so I edit the output of get_maintainers
before using it.
Does --no-git provide the behavior you're both looking for? We should
likely tweak the .get_maintainers.conf file.
Yes, but sometimes this information is nice to see. Maybe we should
tweak --git-min-signatures to 2? That would help exclude a lot of
one-off commits, but it wouldn't help with people modifying unrelated
areas (especially in things like Kconfigs/Makefiles). TBH when including
people by activity, I usually inspect the git log and include only
people who are making semantic changes to the file. Of course, this
doesn't work for files which have had few contributors in the past
year...
--Sean
