Hi Heinrich, On Fri, 9 Sept 2022 at 03:45, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > On 9/9/22 00:12, Simon Glass wrote: > > Hi Heinrich, > > > > On Thu, 8 Sept 2022 at 13:56, Heinrich Schuchardt <xypron.g...@gmx.de> > > wrote: > >> > >> On 9/8/22 20:18, Simon Glass wrote: > >>> Hi Heinrich, > >>> > >>> On Thu, 8 Sept 2022 at 09:53, Heinrich Schuchardt <xypron.g...@gmx.de> > >>> wrote: > >>>> > >>>> On 9/6/22 23:18, Simon Glass wrote: > >>>>> Hi, > >>>>> > >>>>> On Fri, 2 Sept 2022 at 08:22, Masahisa Kojima > >>>>> <masahisa.koj...@linaro.org> wrote: > >>>>>> > >>>>>> Provide a unit test for the eficonfig command. > >>>>>> > >>>>>> Signed-off-by: Masahisa Kojima <masahisa.koj...@linaro.org> > >>>>>> Acked-by: Ilias Apalodimas <ilias.apalodi...@linaro.org> > >>>>>> --- > >>>>>> No update since v15 > >>>>>> > >>>>>> Changes in v14: > >>>>>> - update to support media device enumeration in eficonfig startup > >>>>>> - move no block device test to the last test case > >>>>>> > >>>>>> Changes in v12: > >>>>>> - update menu handling > >>>>>> > >>>>>> Changes in v11: > >>>>>> - fix expected result when no BootOrder is defined > >>>>>> > >>>>>> Newly added in v10 > >>>>>> > >>>>>> configs/sandbox_defconfig | 1 + > >>>>>> test/py/tests/test_eficonfig/conftest.py | 40 ++ > >>>>>> .../py/tests/test_eficonfig/test_eficonfig.py | 350 > >>>>>> ++++++++++++++++++ > >>>>>> 3 files changed, 391 insertions(+) > >>>>>> create mode 100644 test/py/tests/test_eficonfig/conftest.py > >>>>>> create mode 100644 test/py/tests/test_eficonfig/test_eficonfig.py > >>>>> > >>>>> How come this is written in Python? Shouldn't it be in C? > >>>> > >>>> We need to prepare an image for testing and provide it to U-Boot. > >>>> > >>>> This cannot be done with C. > >>> > >>> We do that now with the bootstd tests. Please see setup_bootflow_image(). > >> > >> setup_bootflow_image() uses sudo. For security reasons I don't like to > >> provide root privileges to other people's code. Distributions don't like > >> their builders to run with root privileges. Please, use virt-make-fs > >> instead. > > > > I do agree, but then don't we need to chmod a+r the current kernel? Is > > there a way around that? > > This is a Ubuntu specific "feature". Debian does not have that problem. > > Just create a file > > /etc/initramfs-tools/hooks/vmlinuz (chmod 755) with content > > #!/bin/sh > echo "chmod a+r vmlinuz-*" > chmod a+r /boot/vmlinuz-* > > And run > > update-initramfs -u > > The next time a kernel update is installed the script will be executed > automatically.
Thanks for the info. Can we add this to the docs and print out a message in the test pointing people to this fix? Regards, Simon
